[all-commits] [llvm/llvm-project] be179b: [FastISel] NFC: Remove obsolete -fast-isel-sink-lo...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Jan 11 09:37:48 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: be179b9946f6dfd6e3d957d9f7a6ee992d1f69d2
      https://github.com/llvm/llvm-project/commit/be179b9946f6dfd6e3d957d9f7a6ee992d1f69d2
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
    M llvm/test/CodeGen/AArch64/arm64-abi_align.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-call.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-gv.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-intrinsic.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel.ll
    M llvm/test/CodeGen/AArch64/arm64-patchpoint-webkit_jscc.ll
    M llvm/test/CodeGen/AArch64/swifterror.ll
    M llvm/test/CodeGen/ARM/fast-isel-call.ll
    M llvm/test/CodeGen/ARM/fast-isel-intrinsic.ll
    M llvm/test/CodeGen/ARM/fast-isel-select.ll
    M llvm/test/CodeGen/ARM/fast-isel-vararg.ll
    M llvm/test/CodeGen/ARM/swifterror.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/callabi.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/simplestore.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/simplestorei.ll
    M llvm/test/CodeGen/X86/avx512-mask-zext-bugfix.ll
    M llvm/test/CodeGen/X86/bmi-intrinsics-fast-isel.ll
    M llvm/test/CodeGen/X86/fast-isel-call-cleanup.ll
    M llvm/test/CodeGen/X86/inreg.ll
    M llvm/test/CodeGen/X86/pr32241.ll
    M llvm/test/CodeGen/X86/pr32284.ll
    M llvm/test/CodeGen/X86/pr32340.ll
    M llvm/test/CodeGen/X86/pr32345.ll
    M llvm/test/CodeGen/X86/pr32484.ll
    M llvm/test/CodeGen/X86/sink-local-value.ll
    M llvm/test/CodeGen/X86/sse-intrinsics-fast-isel.ll
    M llvm/test/DebugInfo/Mips/delay-slot.ll
    M llvm/test/DebugInfo/X86/prologue-stack.ll

  Log Message:
  -----------
  [FastISel] NFC: Remove obsolete -fast-isel-sink-local-values option

This option is not used for anything after #c161665 (D91737).
This commit reapplies #a474657.


  Commit: ac2224c02282039f41294842396cbbe47ea29a23
      https://github.com/llvm/llvm-project/commit/ac2224c02282039f41294842396cbbe47ea29a23
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M lld/ELF/Driver.cpp
    A lld/test/ELF/lto/exclude-libs-libcall.ll

  Log Message:
  -----------
  [ELF] --exclude-libs: localize defined libcall symbols referenced by lto.tmp

Fixes PR48681: after LTO, lto.tmp may reference a libcall symbol not in an IR
symbol table of any bitcode file. If such a symbol is defined in an archive
matched by a --exclude-libs, we don't correctly localize the symbol.

Add another `excludeLibs` after `compileBitcodeFiles` to localize such libcall
symbols. Unfortunately we have keep the existing one for D43126.

Using VER_NDX_LOCAL is an implementation detail of `--exclude-libs`, it does not
necessarily tie to the "localize" behavior.  `local:` patterns in a version
script can be omitted.
The `symbol ... has undefined version ...` error should not be exempted.
Ideally we should error as GNU ld does. https://issuetracker.google.com/issues/73020933

Reviewed By: psmith

Differential Revision: https://reviews.llvm.org/D94280


Compare: https://github.com/llvm/llvm-project/compare/c4486cfd5568...ac2224c02282


More information about the All-commits mailing list