[all-commits] [llvm/llvm-project] c16177: [FastISel] Flush local value map on every instruction

[Paul T Robinson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c161775decddcc86fbbfefd7485a5d0ef5842aec
      https://github.com/llvm/llvm-project/commit/c161775decddcc86fbbfefd7485a5d0ef5842aec
  Author: Paul Robinson <Paul.Robinson at sony.com>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M lld/test/wasm/debug-removed-fn.ll
    M lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
    M lldb/test/Shell/SymbolFile/NativePDB/load-pdb.cpp
    M llvm/include/llvm/CodeGen/FastISel.h
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
    M llvm/test/CodeGen/AArch64/arm64-abi_align.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-call.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-gv.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel-intrinsic.ll
    M llvm/test/CodeGen/AArch64/arm64-fast-isel.ll
    M llvm/test/CodeGen/AArch64/arm64-patchpoint-webkit_jscc.ll
    M llvm/test/CodeGen/AArch64/cfguard-checks.ll
    M llvm/test/CodeGen/AArch64/elf-globals-static.ll
    M llvm/test/CodeGen/AArch64/large-stack.ll
    M llvm/test/CodeGen/ARM/fast-isel-call.ll
    M llvm/test/CodeGen/ARM/fast-isel-intrinsic.ll
    M llvm/test/CodeGen/ARM/fast-isel-ldr-str-thumb-neg-index.ll
    M llvm/test/CodeGen/ARM/fast-isel-ldrh-strh-arm.ll
    M llvm/test/CodeGen/ARM/fast-isel-select.ll
    M llvm/test/CodeGen/ARM/fast-isel.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/callabi.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/fastalloca.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/fpcmpa.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/icmpa.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/logopm.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/overflt.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/shftopm.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/simplestore.ll
    M llvm/test/CodeGen/Mips/Fast-ISel/simplestorei.ll
    M llvm/test/CodeGen/Mips/emergency-spill-slot-near-fp.ll
    M llvm/test/CodeGen/PowerPC/elf-common.ll
    M llvm/test/CodeGen/PowerPC/fast-isel-load-store.ll
    M llvm/test/CodeGen/PowerPC/mcm-1.ll
    M llvm/test/CodeGen/PowerPC/mcm-13.ll
    M llvm/test/CodeGen/PowerPC/mcm-2.ll
    M llvm/test/CodeGen/PowerPC/mcm-3.ll
    M llvm/test/CodeGen/PowerPC/mcm-6.ll
    M llvm/test/CodeGen/PowerPC/mcm-9.ll
    M llvm/test/CodeGen/PowerPC/mcm-default.ll
    M llvm/test/CodeGen/X86/atomic-unordered.ll
    M llvm/test/CodeGen/X86/atomic64.ll
    M llvm/test/CodeGen/X86/crash-O0.ll
    R llvm/test/CodeGen/X86/fast-isel-constant.ll
    M llvm/test/CodeGen/X86/fast-isel-mem.ll
    A llvm/test/CodeGen/X86/fast-isel-prolog-dbgloc.ll
    M llvm/test/CodeGen/X86/fast-isel-select.ll
    M llvm/test/CodeGen/X86/lvi-hardening-loads.ll
    M llvm/test/CodeGen/X86/membarrier.ll
    M llvm/test/CodeGen/X86/pr32241.ll
    M llvm/test/CodeGen/X86/pr32256.ll
    M llvm/test/CodeGen/X86/pr32284.ll
    M llvm/test/CodeGen/X86/pr32340.ll
    M llvm/test/CodeGen/X86/pr44749.ll
    M llvm/test/CodeGen/X86/volatile.ll
    M llvm/test/DebugInfo/COFF/lines-bb-start.ll
    M llvm/test/DebugInfo/Mips/delay-slot.ll
    M llvm/test/DebugInfo/X86/fission-ranges.ll

  Log Message:
  -----------
  [FastISel] Flush local value map on every instruction

Local values are constants or addresses that can't be folded into
the instruction that uses them. FastISel materializes these in a
"local value" area that always dominates the current insertion
point, to try to avoid materializing these values more than once
(per block).

https://reviews.llvm.org/D43093 added code to sink these local
value instructions to their first use, which has two beneficial
effects. One, it is likely to avoid some unnecessary spills and
reloads; two, it allows us to attach the debug location of the
user to the local value instruction. The latter effect can
improve the debugging experience for debuggers with a "set next
statement" feature, such as the Visual Studio debugger and PS4
debugger, because instructions to set up constants for a given
statement will be associated with the appropriate source line.

There are also some constants (primarily addresses) that could be
produced by no-op casts or GEP instructions; the main difference
from "local value" instructions is that these are values from
separate IR instructions, and therefore could have multiple users
across multiple basic blocks. D43093 avoided sinking these, even
though they were emitted to the same "local value" area as the
other instructions. The patch comment for D43093 states:

  Local values may also be used by no-op casts, which adds the
  register to the RegFixups table. Without reversing the RegFixups
  map direction, we don't have enough information to sink these
  instructions.

This patch undoes most of D43093, and instead flushes the local
value map after(*) every IR instruction, using that instruction's
debug location. This avoids sometimes incorrect locations used
previously, and emits instructions in a more natural order.

In addition, constants materialized due to PHI instructions are
not assigned a debug location immediately; instead, when the
local value map is flushed, if the first local value instruction
has no debug location, it is given the same location as the
first non-local-value-map instruction.  This prevents PHIs
from introducing unattributed instructions, which would either
be implicitly attributed to the location for the preceding IR
instruction, or given line 0 if they are at the beginning of
a machine basic block.  Neither of those consequences is good
for debugging.

This does mean materialized values are not re-used across IR
instruction boundaries; however, only about 5% of those values
were reused in an experimental self-build of clang.

(*) Actually, just prior to the next instruction. It seems like
it would be cleaner the other way, but I was having trouble
getting that to work.

This reapplies commits cf1c774d and dc35368c, and adds the
modification to PHI handling, which should avoid problems
with debugging under gdb.

Differential Revision: https://reviews.llvm.org/D91734