[all-commits] [llvm/llvm-project] 971006: Reapply "[clang][cli] Port DiagnosticOpts to new o...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 97100646d1b4526de1eac3aacdb0b098739c6ec9
      https://github.com/llvm/llvm-project/commit/97100646d1b4526de1eac3aacdb0b098739c6ec9
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticOptions.h
    M clang/include/clang/Driver/Options.td
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/unittests/Frontend/CompilerInvocationTest.cpp
    M llvm/include/llvm/Option/OptParser.td
    M llvm/utils/TableGen/OptParserEmitter.cpp

  Log Message:
  -----------
  Reapply "[clang][cli] Port DiagnosticOpts to new option parsing system"

This reverts commit 8e3e148c

This commit fixes two issues with the original patch:
* The sanitizer build bot reported an uninitialized value. This was caused by normalizeStringIntegral not returning None on failure.
* Some build bots complained about inaccessible keypaths. To mitigate that, "this->" was added back to the keypath to restore the previous behavior.