[all-commits] [llvm/llvm-project] 01f0d1: Moving UniqueInternalLinkageNamesPass to the start...

Hongtao Yu via All-commits all-commits at lists.llvm.org
Sat Jan 2 14:30:44 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 01f0d162d672c02b7207e0b3a6c494c4d0ea513d
      https://github.com/llvm/llvm-project/commit/01f0d162d672c02b7207e0b3a6c494c4d0ea513d
  Author: Hongtao Yu <hoy at fb.com>
  Date:   2021-01-02 (Sat, 02 Jan 2021)

  Changed paths:
    M llvm/include/llvm/Passes/PassBuilder.h
    M llvm/lib/Passes/PassBuilder.cpp
    A llvm/test/Other/new-pm-pseudo-probe.ll
    A llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll
    M llvm/tools/opt/NewPMDriver.cpp

  Log Message:
  -----------
  Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

`UniqueInternalLinkageNamesPass` is useful to CSSPGO, especially when pseudo probe is used. It solves naming conflict for static functions which otherwise will share a merged profile and likely have a profile quality issue with mismatched CFG checksums. Since the pseudo probe instrumentation happens very early in the pipeline, I'm moving `UniqueInternalLinkageNamesPass` right before it. This is being done only to the new pass manager.

Reviewed By: dblaikie, aeubanks

Differential Revision: https://reviews.llvm.org/D93656




More information about the All-commits mailing list