[all-commits] [llvm/llvm-project] c182a0: [Analysis] fix typo in code comment; NFC

[RotateRight via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c182a000954de667f1e87055bf0329e5e6f52f1f
      https://github.com/llvm/llvm-project/commit/c182a000954de667f1e87055bf0329e5e6f52f1f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-01-01 (Fri, 01 Jan 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/IVDescriptors.h

  Log Message:
  -----------
  [Analysis] fix typo in code comment; NFC


  Commit: c74e8539ff372a89d08e7bfea7323a4dc2979d22
      https://github.com/llvm/llvm-project/commit/c74e8539ff372a89d08e7bfea7323a4dc2979d22
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-01-01 (Fri, 01 Jan 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/IVDescriptors.h
    M llvm/include/llvm/Transforms/Utils/LoopUtils.h
    M llvm/lib/Analysis/IVDescriptors.cpp
    M llvm/lib/CodeGen/ExpandReductions.cpp
    M llvm/lib/Transforms/Utils/LoopUtils.cpp
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
    M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

  Log Message:
  -----------
  [Analysis] flatten enums for recurrence types

This is almost all mechanical search-and-replace and
no-functional-change-intended (NFC). Having a single
enum makes it easier to match/reason about the
reduction cases.

The goal is to remove `Opcode` from reduction matching
code in the vectorizers because that makes it harder to
adapt the code to handle intrinsics.

The code in RecurrenceDescriptor::AddReductionVar() is
the only place that required closer inspection. It uses
a RecurrenceDescriptor and a second InstDesc to sometimes
overwrite part of the struct. It seem like we should be
able to simplify that logic, but it's not clear exactly
which cmp+sel patterns that we are trying to handle/avoid.


Compare: https://github.com/llvm/llvm-project/compare/bf2a78fd4ae9...c74e8539ff37