[all-commits] [llvm/llvm-project] 6b316f: [OpenMP] libomp: Handle implicit conversion warnings

[Terry Wilmarth via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b316febb4388764789677f81f03aff373ec35b2
      https://github.com/llvm/llvm-project/commit/6b316febb4388764789677f81f03aff373ec35b2
  Author: Terry Wilmarth <terry.l.wilmarth at intel.com>
  Date:   2020-12-31 (Thu, 31 Dec 2020)

  Changed paths:
    M openmp/runtime/cmake/LibompHandleFlags.cmake
    M openmp/runtime/cmake/config-ix.cmake
    M openmp/runtime/src/kmp.h
    M openmp/runtime/src/kmp_affinity.cpp
    M openmp/runtime/src/kmp_affinity.h
    M openmp/runtime/src/kmp_alloc.cpp
    M openmp/runtime/src/kmp_atomic.cpp
    M openmp/runtime/src/kmp_barrier.cpp
    M openmp/runtime/src/kmp_csupport.cpp
    M openmp/runtime/src/kmp_dispatch.cpp
    M openmp/runtime/src/kmp_dispatch_hier.h
    M openmp/runtime/src/kmp_environment.cpp
    M openmp/runtime/src/kmp_ftn_entry.h
    M openmp/runtime/src/kmp_gsupport.cpp
    M openmp/runtime/src/kmp_i18n.h
    M openmp/runtime/src/kmp_itt.inl
    M openmp/runtime/src/kmp_lock.cpp
    M openmp/runtime/src/kmp_runtime.cpp
    M openmp/runtime/src/kmp_settings.cpp
    M openmp/runtime/src/kmp_stats.cpp
    M openmp/runtime/src/kmp_stats.h
    M openmp/runtime/src/kmp_str.cpp
    M openmp/runtime/src/kmp_str.h
    M openmp/runtime/src/kmp_stub.cpp
    M openmp/runtime/src/kmp_stub.h
    M openmp/runtime/src/kmp_taskdeps.cpp
    M openmp/runtime/src/kmp_tasking.cpp
    M openmp/runtime/src/kmp_threadprivate.cpp
    M openmp/runtime/src/kmp_utility.cpp
    M openmp/runtime/src/kmp_wait_release.h
    M openmp/runtime/src/ompt-specific.cpp
    M openmp/runtime/src/z_Linux_util.cpp

  Log Message:
  -----------
  [OpenMP] libomp: Handle implicit conversion warnings

This patch partially prepares the runtime source code to be built with
-Wconversion, which should trigger warnings if any implicit conversions
can possibly change a value. For builds done with icc or gcc, all such
warnings are handled in this patch. clang gives a much longer list of
warnings, particularly for sign conversions, which the other compilers
don't report. The -Wconversion flag is commented into cmake files, but
I'm not going to turn it on. If someone thinks it is important, and wants
to fix all the clang warnings, they are welcome to.

Types of changes made here involve either improving the consistency of types
used so that no conversion is needed, or else performing careful explicit
conversions, when we're sure a problem won't arise.

Patch is a combination of changes by Terry Wilmarth and Johnny Peyton.

Differential Revision: https://reviews.llvm.org/D92942