[all-commits] [llvm/llvm-project] e90ea7: [IR] remove 'NoNan' param when creating FP reductions

RotateRight via All-commits all-commits at lists.llvm.org
Wed Dec 30 06:56:28 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e90ea76380d411bf81861228f23e4716ef337100
      https://github.com/llvm/llvm-project/commit/e90ea76380d411bf81861228f23e4716ef337100
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-12-30 (Wed, 30 Dec 2020)

  Changed paths:
    M llvm/include/llvm/IR/IRBuilder.h
    M llvm/lib/IR/IRBuilder.cpp
    M llvm/lib/Transforms/Utils/LoopUtils.cpp

  Log Message:
  -----------
  [IR] remove 'NoNan' param when creating FP reductions

This is no-functional-change-intended (AFAIK, we can't
isolate this difference in a regression test).

That's because the callers should be setting the IRBuilder's
FMF field when creating the reduction and/or setting those
flags after creating. It doesn't make sense to override this
one flag alone.

This is part of a multi-step process to clean up the FMF
setting/propagation. See PR35538 for an example.




More information about the All-commits mailing list