[all-commits] [llvm/llvm-project] 4ddf14: Fix PR35902: incorrect alignment used for ubsan ch...

James Y Knight via All-commits all-commits at lists.llvm.org
Mon Dec 28 15:37:21 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ddf140c00408ecee9d20f4470e69e0f696d8f8a
      https://github.com/llvm/llvm-project/commit/4ddf140c00408ecee9d20f4470e69e0f696d8f8a
  Author: James Y Knight <jyknight at google.com>
  Date:   2020-12-28 (Mon, 28 Dec 2020)

  Changed paths:
    M clang/lib/CodeGen/CGCXXABI.cpp
    M clang/lib/CodeGen/CodeGenFunction.cpp
    M clang/test/CodeGenCXX/catch-undef-behavior.cpp

  Log Message:
  -----------
  Fix PR35902: incorrect alignment used for ubsan check.

UBSan was using the complete-object align rather than nv alignment
when checking the "this" pointer of a method.

Furthermore, CGF.CXXABIThisAlignment was also being set incorrectly,
due to an incorrectly negated test. The latter doesn't appear to have
had any impact, due to it not really being used anywhere.

Differential Revision: https://reviews.llvm.org/D93072




More information about the All-commits mailing list