[all-commits] [llvm/llvm-project] 25007b: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/se...

[Rahul Joshi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 25007b4d7e094c569d512770bd2397d8667fd3db
      https://github.com/llvm/llvm-project/commit/25007b4d7e094c569d512770bd2397d8667fd3db
  Author: Rahul Joshi <jurahul at google.com>
  Date:   2020-12-28 (Mon, 28 Dec 2020)

  Changed paths:
    M mlir/include/mlir/IR/FunctionSupport.h

  Log Message:
  -----------
  [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update.

- Change FunctionLike::setAllArgAttrs() and setAllResultAttrs() to rebuild the new list of
  function attributes locally and call setAttr() just once instead of calling
  setArgAttr()/setResultAttrs() for each argument which incrementally build the
  attribute dictionary and can end up creating a lot of unused DictionaryAttr's (which are
  uniqued and nor garbage collected).

Differential Revision: https://reviews.llvm.org/D93870