[all-commits] [llvm/llvm-project] a485a5: [benchmark] Fixed a build error when using CMake 3...

AnzhongHuang via All-commits all-commits at lists.llvm.org
Mon Dec 28 00:26:33 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a485a59d2172daaee1d5e734da54fbb243f7d54c
      https://github.com/llvm/llvm-project/commit/a485a59d2172daaee1d5e734da54fbb243f7d54c
  Author: AnZhong Huang <Anzhong.huang at amd.com>
  Date:   2020-12-28 (Mon, 28 Dec 2020)

  Changed paths:
    M llvm/utils/benchmark/include/benchmark/benchmark.h

  Log Message:
  -----------
  [benchmark] Fixed a build error when using CMake 3.15.1 + NDK-R20

std::decay_t used by llvm/utils/benchmark/include/benchmark/benchmark.h
is a c++14 feature, but the CMakelist uses c++11,
it's the root-cause of build error.

There are two options to fix the error.
1) change the CMakelist to support c++14.
2) change std::decay_t to std::decay, it's what the patch done.

This bug can only be reproduced by CMake 3.15, we didn't observer the bug
with CMake 3.16. But based on the code's logic, it's an obvious bug of LLVM.

The upstream code is fine, the problem was introduced by
rG1bd6123b781120c9190b9ba58b900cdcb718cdd1.

Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D93794




More information about the All-commits mailing list