[all-commits] [llvm/llvm-project] bc633f: [Polly] Consider InvalidContext to determine parti...

[Michael Kruse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc633fe46bbec1cf70d4a3f740da43888979d8c6
      https://github.com/llvm/llvm-project/commit/bc633fe46bbec1cf70d4a3f740da43888979d8c6
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2020-12-10 (Thu, 10 Dec 2020)

  Changed paths:
    M polly/include/polly/Support/ISLTools.h
    M polly/lib/Analysis/ScopInfo.cpp
    M polly/lib/Support/ISLTools.cpp
    A polly/test/DeLICM/load-in-cond-inf-loop.ll

  Log Message:
  -----------
  [Polly] Consider InvalidContext to determine partial READ.

MemoryAccess::setNewAccessRelation() in assert-builds checks whether the
access relation for a READ has a memory location for every instance of
the domain. Otherwise, we would not have value to load from. That check
already considered that instances outside the Scop's context do not
matter since they are never executed (or would be undefined behavior).
In this patch also take instances of the InvalidContext into account,
as these can also be assumed to never occur. InvalidContext was
introduced to avoid the computational complexity of subtracting
restrictions from the AssumedContext. However, this additional check in
setNewAccessRelation is only done in assert-builds.

The assertion case with an InvalidContext may occur with DeLICM on a
conditionally infinite loops, as it is the case in the following code:

    for (int i = 0; i < n; i+=b)
      vreg = ...;
    *Dest = vreg;

The loop is infinite when b=0, and [b] -> { : b = 0 }  is part of the
InvalidContext. When DeLICM tries to map the memory for %vreg to *Dest,
there is no store instance that uses the value of vreg when b = 0, hence
no location to map it to. However, the case is irrelevant since Polly's
runtime condition check ensures that this is never case.

Fixes llvm.org/PR48445