[all-commits] [llvm/llvm-project] 89a0f4: [libomptarget][cuda] Detect missing symbols in plu...
Jon Chesterfield via All-commits
all-commits at lists.llvm.org
Fri Nov 27 07:40:09 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 89a0f48c58f82262c7ce2b9ca51ffad0ffc559ea
https://github.com/llvm/llvm-project/commit/89a0f48c58f82262c7ce2b9ca51ffad0ffc559ea
Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
Date: 2020-11-27 (Fri, 27 Nov 2020)
Changed paths:
M openmp/libomptarget/plugins/cuda/CMakeLists.txt
Log Message:
-----------
[libomptarget][cuda] Detect missing symbols in plugin at build time
[libomptarget][cuda] Detect missing symbols in plugin at build time
Passes -z,defs to the linker. Error on unresolved symbol references.
Otherwise, those unresolved symbols present as target code running on the host
as the plugin fails to load. This is significantly harder to debug than a link
time error. Flag matches that passed by amdgcn and ve plugins.
Reviewed By: tianshilei1992
Differential Revision: https://reviews.llvm.org/D92143
More information about the All-commits
mailing list