[all-commits] [llvm/llvm-project] 668da8: [MC] Set the unique id of .stack_sizes to the asso...
Fangrui Song via All-commits
all-commits at lists.llvm.org
Thu Nov 26 09:17:25 PST 2020
Branch: refs/heads/temp-test-main
Home: https://github.com/llvm/llvm-project
Commit: 668da8c361fef5ada092534d4d20ea450831f6f6
https://github.com/llvm/llvm-project/commit/668da8c361fef5ada092534d4d20ea450831f6f6
Author: Fangrui Song <i at maskray.me>
Date: 2020-11-26 (Thu, 26 Nov 2020)
Changed paths:
M llvm/lib/MC/MCObjectFileInfo.cpp
M llvm/test/CodeGen/X86/stack-size-section-function-sections.ll
Log Message:
-----------
[MC] Set the unique id of .stack_sizes to the associated .text section's
Similar to D92113. Currently `clang -fstack-size-section -fno-unique-section-names`
sets the linked-to symbol to the first `.text`, which is:
* incorrect for COMDAT sections
* inferior for non-COMDAT sections in -ffunction-sections mode (poor --gc-sections: .stack_sizes cannot be separately discarded)
Note, if the section symbol can be referenced in more places (if the
function begin symbol does not apply), we probably should consider
defining a different BeginSymbol for sections with ",unique" linkage.
Reviewed By: grimar, jhenderson
Differential Revision: https://reviews.llvm.org/D92151
More information about the All-commits
mailing list