[all-commits] [llvm/llvm-project] 1363df: [CodeView] Avoid emitting empty debug globals subs...

Amy Huang via All-commits all-commits at lists.llvm.org
Wed Nov 25 16:18:14 PST 2020


  Branch: refs/heads/temp-test-main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1363dfaf3105470e1724ed1f17c6d9c0713f442e
      https://github.com/llvm/llvm-project/commit/1363dfaf3105470e1724ed1f17c6d9c0713f442e
  Author: Amy Huang <akhuang at google.com>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M lld/COFF/PDB.cpp
    A lld/test/COFF/empty-subsection.s
    M llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
    A llvm/test/DebugInfo/COFF/empty-globals-subsection.ll

  Log Message:
  -----------
  [CodeView] Avoid emitting empty debug globals subsection.

In https://reviews.llvm.org/D89072 I added static const data members
to the debug subsection for globals. It skipped emitting an S_CONSTANT if it
didn't have a value, which meant the subsection could be empty.

This patch fixes the empty subsection issue.

Differential Revision: https://reviews.llvm.org/D92049




More information about the All-commits mailing list