[all-commits] [llvm/llvm-project] b281a0: [OpenMP][OMPT] Implement verbose tool loading

[Joachim via All-commits]

  Branch: refs/heads/temp-test-main
  Home:   https://github.com/llvm/llvm-project
  Commit: b281a05dacb485d3c3c9cc7f7f5e8fb858ac67bc
      https://github.com/llvm/llvm-project/commit/b281a05dacb485d3c3c9cc7f7f5e8fb858ac67bc
  Author: Isabel Thärigen <thaerigen at itc.rwth-aachen.de>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M openmp/runtime/src/kmp_settings.cpp
    M openmp/runtime/src/ompt-general.cpp
    M openmp/runtime/test/ompt/loadtool/tool_available/tool_available.c
    M openmp/runtime/test/ompt/loadtool/tool_available_search/tool_available_search.c
    M openmp/runtime/test/ompt/loadtool/tool_not_available/tool_not_available.c
    M openmp/tools/archer/tests/parallel/parallel-simple.c

  Log Message:
  -----------
  [OpenMP][OMPT] Implement verbose tool loading

OpenMP 5.1 introduces the new env variable
OMP_TOOL_VERBOSE_INIT=(disabled|stdout|stderr|<filename>) to enable verbose
loading and initialization of OMPT tools.
This env variable helps to understand the cause when loading of a tool fails
(e.g., undefined symbols or dependency not in LD_LIBRARY_PATH)
Output of OMP_TOOL_VERBOSE_INIT is added for OMP_DISPLAY_ENV

Tests for this patch are integrated into the different existing tool loading
tests, making these tests more verbose. An Archer specific verbose test is
integrated into an existing Archer test.

Patch prepared by: Isabel Thärigen

Differential Revision: https://reviews.llvm.org/D91464


  Commit: 6d3b81664a4b79b32ed2c2f46b21ab0dca9029cc
      https://github.com/llvm/llvm-project/commit/6d3b81664a4b79b32ed2c2f46b21ab0dca9029cc
  Author: Joachim Protze <protze at itc.rwth-aachen.de>
  Date:   2020-11-25 (Wed, 25 Nov 2020)

  Changed paths:
    M openmp/runtime/src/kmp_csupport.cpp
    M openmp/runtime/src/kmp_gsupport.cpp
    M openmp/runtime/src/ompt-specific.h
    A openmp/runtime/test/ompt/parallel/repeated_calls.c

  Log Message:
  -----------
  [OpenMP][OMPT] Introduce a guard to handle OMPT return address

This is an alternative approach to address inconsistencies pointed out in: D90078
This patch makes sure that the return address is reset, when leaving the scope.
In some cases, I had to move the macro out of an if-statement to have it in the
right scope, in some cases I added an additional block to restrict the scope.

This patch does not handle inconsistencies, which might occur if the return
address is still set when we call into the application.

Test case (repeated_calls.c) provided by @hbae

Differential Revision: https://reviews.llvm.org/D91692


Compare: https://github.com/llvm/llvm-project/compare/9595a7ff55b6...6d3b81664a4b