[all-commits] [llvm/llvm-project] a248ec: Clear NewGEPBases after finish using them in CodeG...

Yichao Yu via All-commits all-commits at lists.llvm.org
Tue Nov 24 09:12:34 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a248eca6659779116a6fb348117d74a0b8a05316
      https://github.com/llvm/llvm-project/commit/a248eca6659779116a6fb348117d74a0b8a05316
  Author: Yichao Yu <yyc1992 at gmail.com>
  Date:   2020-11-24 (Tue, 24 Nov 2020)

  Changed paths:
    M llvm/lib/CodeGen/CodeGenPrepare.cpp

  Log Message:
  -----------
  Clear NewGEPBases after finish using them in CodeGenPrep pass

AFAICT all other set/map are correctly cleared in `runOnFunction`.

With assertion enabled this causes a crash when the module is freed and potentially if a later pass delete the instruction (not observed in real world though). Without assertion this can potentially cause confusing result when running on a new Function/Module.

Reviewed By: loladiro

Differential Revision: https://reviews.llvm.org/D84031




More information about the All-commits mailing list