[all-commits] [llvm/llvm-project] 5ce85e: Fix driver test from e16c0a9a689719

Nico Weber via All-commits all-commits at lists.llvm.org
Tue Nov 24 07:51:46 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ce85e66358a69e786093756c77fae2e140947c1
      https://github.com/llvm/llvm-project/commit/5ce85e66358a69e786093756c77fae2e140947c1
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-11-24 (Tue, 24 Nov 2020)

  Changed paths:
    A clang/test/Driver/Inputs/lld/ld64.lld
    A clang/test/Driver/Inputs/lld/ld64.lld.darwinnew
    M clang/test/Driver/darwin-ld-demangle-lld.c

  Log Message:
  -----------
  Fix driver test from e16c0a9a689719

The test failed silently if lld wasn't built alongside clang.
But the test uses -###, so the "invalid linker name in -fuse-ld=lld"
diag didn't make clang fail, and something else happened to match
"-demangle", so the test passed.

To fix, pass -B to a directory with two empty +x files (which works
on non-Windows), and look for `"-demangle"` instead of just `-demangle`.
Also force linker_version to 0 and pass a darwin triple.

Differential Revision: https://reviews.llvm.org/D92028




More information about the All-commits mailing list