[all-commits] [llvm/llvm-project] be00e8: [libc++] Clarify how we pick the typeinfo comparison

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Nov 18 13:59:06 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: be00e8893fdb814e67d8f06401afe869f878c4cf
      https://github.com/llvm/llvm-project/commit/be00e8893fdb814e67d8f06401afe869f878c4cf
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/cmake/caches/Apple.cmake
    M libcxx/docs/BuildingLibcxx.rst
    M libcxx/include/__config
    M libcxx/include/__config_site.in
    M libcxx/include/typeinfo

  Log Message:
  -----------
  [libc++] Clarify how we pick the typeinfo comparison

This commit makes it clear that the typeinfo comparison implementation
is automatically selected by default, and that the CMake option only
overrides the value. This has been a source of confusion and bugs ever
since we've introduced complexity in that area, so I'm trying to simplify
it while still allowing for some control on the implementation.

Differential Revision: https://reviews.llvm.org/D91574




More information about the All-commits mailing list