[all-commits] [llvm/llvm-project] c29882: [MLIR] Check for duplicate entries in attribute di...

[Rahul Joshi via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c298824f9caf407aedeb4958467fb2a18025638d
      https://github.com/llvm/llvm-project/commit/c298824f9caf407aedeb4958467fb2a18025638d
  Author: Rahul Joshi <jurahul at google.com>
  Date:   2020-11-03 (Tue, 03 Nov 2020)

  Changed paths:
    M mlir/include/mlir/IR/Attributes.h
    M mlir/include/mlir/IR/OperationSupport.h
    M mlir/lib/IR/Attributes.cpp
    M mlir/lib/IR/OperationSupport.cpp
    M mlir/lib/Parser/AttributeParser.cpp
    M mlir/lib/Parser/Parser.cpp
    M mlir/test/IR/invalid.mlir

  Log Message:
  -----------
  [MLIR] Check for duplicate entries in attribute dictionary during custom parsing

- Verify that attributes parsed using a custom parser do not have duplicates.
- If there are duplicated in the attribute dictionary in the input, they get caught during the
  dictionary parsing.
- This check verifies that there is no duplication between the parsed dictionary and any
  attributes that might be added by the custom parser (or when the custom parsing code
  adds duplicate attributes).
- Fixes https://bugs.llvm.org/show_bug.cgi?id=48025

Differential Revision: https://reviews.llvm.org/D90502