[all-commits] [llvm/llvm-project] 1ed2ca: [flang][driver] Use --match-full-lines in tests fo...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Mon Nov 2 02:01:45 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ed2ca68191fb280161ee8f8cd080640db6be710
      https://github.com/llvm/llvm-project/commit/1ed2ca68191fb280161ee8f8cd080640db6be710
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M flang/test/Frontend/input-output-file.f90
    M flang/test/Frontend/multiple-input-files.f90

  Log Message:
  -----------
  [flang][driver] Use --match-full-lines in tests for `-test-io`

Use `--match-full-lines` to make sure that FileCheck doesn't match the
output against the `CHECK` lines (which, like other comments, are also
printed).

More specifically, we want to make sure that the following `check` in the
input file:
```
! CHECK: <some-fortran-input>
```
is matched by FileCheck with `<some-fortran-input>` in the generated
output. Without `--match-full-lines`, that check-line will be matched
with `!CHECK:  <some-fortran-input>` instead (which is also
printed together with other contents of the file).

Adding `--match-full-lines` makes the tests stricter and this change
revealed that some `check`s were passing only because that flag was
missing. These are updated accordingly.

Reviewed By: CarolineConcatto, sameeranjoshi

Differential Revision: https://reviews.llvm.org/D90306




More information about the All-commits mailing list