[all-commits] [llvm/llvm-project] d0beda: [clangd] Improve remote-index test

[Kirill Bobyrev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d0beda1b66617cda8a1f54978fca72832496b1fb
      https://github.com/llvm/llvm-project/commit/d0beda1b66617cda8a1f54978fca72832496b1fb
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M clang-tools-extra/clangd/test/remote-index/pipeline_helper.py

  Log Message:
  -----------
  [clangd] Improve remote-index test

Introduce a separate thread that will kill `clangd-index-server` after 10 seconds regardless. This helps shut down the test if the server hangs and `stderr.readline()` does not contain inititalizatiton message. It prevents "necessary" waiting delay for the server warm-up and only introduces additional delay if the test fails.

It also makes use of `subprocess.Popen.kill()` which is a portable way of handling process shutdown and avoids using signals.

Reviewed By: kadircet

Differential Revision: https://reviews.llvm.org/D90590