[all-commits] [llvm/llvm-project] fb3794: [AMDGPU] Update Memory Model in AMDGPUUsage.rst

Scott Linder via All-commits all-commits at lists.llvm.org
Thu Oct 29 16:10:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fb37943cc8be4d5eb1cf7adf4f0b99afcd3f2904
      https://github.com/llvm/llvm-project/commit/fb37943cc8be4d5eb1cf7adf4f0b99afcd3f2904
  Author: Scott Linder <Scott.Linder at amd.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M llvm/docs/AMDGPUUsage.rst

  Log Message:
  -----------
  [AMDGPU] Update Memory Model in AMDGPUUsage.rst

Mostly NFC, but some changes are "bug fixes" rather than just e.g.
formatting changes or typo corrections.

- Fix typo "competing" -> "completing".
- Document why waintcnt is added to stores and not loads for
  sequentially consistent ordering.
- Lowercase some mentions of `buffer_gl{0,1}_inv`.
- Make mentions of `*cnt(0)` consistently include the `(0)` count.
- Remove some mentions of instructions for incorrect address spaces. For
  example, remove mention of `flat_load` from
  `load atomic acquire workgroup global`.
- Re-flow some text to get all the target columns to fit in a
  32-character wide column. Makes a future NFC patch to make these columns
  both 32-character wide more straightforward.

Modified cherry-pick of patch by Tony Tye

Reviewed By: t-tye

Differential Revision: https://reviews.llvm.org/D89596


  Commit: 580f99bcff31f4536aeba3d625139e16ba9c7b64
      https://github.com/llvm/llvm-project/commit/580f99bcff31f4536aeba3d625139e16ba9c7b64
  Author: Scott Linder <Scott.Linder at amd.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M llvm/docs/AMDGPUUsage.rst

  Log Message:
  -----------
  [NFC][AMDGPU] Resize Memory Model columns in AMDGPUUsage.rst

Make all of the "AMDGPU Machine Code GFX*" columns in the Memory Model
table a consistent width of 32-characters.

Best viewed with something like --word-diff

Differential Revision: https://reviews.llvm.org/D89977


Compare: https://github.com/llvm/llvm-project/compare/3591721ada99...580f99bcff31


More information about the All-commits mailing list