[all-commits] [llvm/llvm-project] 359172: [GWP-ASan] Add mutexes for Fuchsia

[Kostya Kortchinsky via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3591721ada99810aeddfa3d4c83eea0dbeed7f18
      https://github.com/llvm/llvm-project/commit/3591721ada99810aeddfa3d4c83eea0dbeed7f18
  Author: Kostya Kortchinsky <kostyak at google.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M compiler-rt/lib/gwp_asan/CMakeLists.txt
    M compiler-rt/lib/gwp_asan/mutex.h
    A compiler-rt/lib/gwp_asan/platform_specific/mutex_fuchsia.cpp
    A compiler-rt/lib/gwp_asan/platform_specific/mutex_fuchsia.h
    A compiler-rt/lib/gwp_asan/platform_specific/mutex_posix.h

  Log Message:
  -----------
  [GWP-ASan] Add mutexes for Fuchsia

Mitch expressed a preference to not have `#ifdef`s in platform agnostic
code, this change tries to accomodate this.

I am not attached to the method this CL proposes, so if anyone has a
suggestion, I am open.

We move the platform specific member of the mutex into its own platform
specific class that the main `Mutex` class inherits from. Functions are
implemented in their respective platform specific compilation units.

For Fuchsia, we use the sync APIs, as those are also the ones being
used in Scudo.

Differential Revision: https://reviews.llvm.org/D90351