[all-commits] [llvm/llvm-project] 6536d6: Revert "[SVE][CodeGen][DAGCombiner] Fix TypeSize w...

[Peter Waller via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6536d6040f5cd20d554901e265519b80dd8119f2
      https://github.com/llvm/llvm-project/commit/6536d6040f5cd20d554901e265519b80dd8119f2
  Author: Peter Waller <peter.waller at arm.com>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AArch64/Redundantstore.ll

  Log Message:
  -----------
  Revert "[SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination"

This reverts commit 4604441386dc5fcd3165f4b39f5fa2e2c600f1bc.

Reverting because it was not the intended version of the patch, which
follows this patch.


  Commit: 5b742a0c106fbed11779d6dd99854a6f97643524
      https://github.com/llvm/llvm-project/commit/5b742a0c106fbed11779d6dd99854a6f97643524
  Author: Peter Waller <peter.waller at arm.com>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    A llvm/test/CodeGen/AArch64/sve-redundant-store.ll

  Log Message:
  -----------
  [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination

The modified code in visitSTORE was missing a scalable vector check, and still
using the now deprecated implicit cast of TypeSize to uint64_t through the
overloaded operator. This patch fixes these issues.

This brings the logic in line with the comment on the context line immediately
above the added precondition.

Add a test in sve-redundant-store.ll that the warning is not triggered.

Differential Revision: https://reviews.llvm.org/D89701


Compare: https://github.com/llvm/llvm-project/compare/4604441386dc...5b742a0c106f