[all-commits] [llvm/llvm-project] 460444: [SVE][CodeGen][DAGCombiner] Fix TypeSize warning i...

Peter Waller via All-commits all-commits at lists.llvm.org
Mon Oct 26 09:25:02 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4604441386dc5fcd3165f4b39f5fa2e2c600f1bc
      https://github.com/llvm/llvm-project/commit/4604441386dc5fcd3165f4b39f5fa2e2c600f1bc
  Author: Peter Waller <peter.waller at arm.com>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AArch64/Redundantstore.ll

  Log Message:
  -----------
  [SVE][CodeGen][DAGCombiner] Fix TypeSize warning in redundant store elimination

The modified code in visitSTORE was missing a scalable vector check, and still
using the now deprecated implicit cast of TypeSize to uint64_t through the
overloaded operator. This patch fixes these issues.

This brings the logic in line with the comment on the context line immediately
above the added precondition.

Add a test in Redundantstores.ll that the warning is not triggered.




More information about the All-commits mailing list