[all-commits] [llvm/llvm-project] 0c8f9b: [MLIR][SPIRV] Add initial support for OpSpecConsta...

Kareem Ergawy via All-commits all-commits at lists.llvm.org
Fri Oct 2 12:18:41 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c8f9b8099fd0500cd885bc699924e20371014ff
      https://github.com/llvm/llvm-project/commit/0c8f9b8099fd0500cd885bc699924e20371014ff
  Author: ergawy <kareem.ergawy at gmail.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td
    M mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
    M mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp
    M mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
    M mlir/test/Dialect/SPIRV/Serialization/spec-constant.mlir
    M mlir/test/Dialect/SPIRV/structure-ops.mlir

  Log Message:
  -----------
  [MLIR][SPIRV] Add initial support for OpSpecConstantComposite.

This commit adds support to SPIR-V's composite specialization constants.
These are specialization constants which are composed of other spec
constants (whehter scalar or composite), regular constatns, or undef
values.

This commit adds support for parsing, printing, verification, and
(De)serialization.

A few TODOs are still in order:
- Supporting more types of constituents; currently, only scalar spec constatns are supported.
- Extending `spv._reference_of` to support composite spec constatns.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D88568




More information about the All-commits mailing list