[all-commits] [llvm/llvm-project] afb4e0: [AArch64] Omit SEH directives for the epilogue if ...

[Martin Storsjö via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: afb4e0f289ac6d020faafda078642a3716629abd
      https://github.com/llvm/llvm-project/commit/afb4e0f289ac6d020faafda078642a3716629abd
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
    M llvm/test/CodeGen/AArch64/lrint-conv-fp16-win.ll
    M llvm/test/CodeGen/AArch64/lrint-conv-win.ll
    M llvm/test/CodeGen/AArch64/lround-conv-fp16-win.ll
    M llvm/test/CodeGen/AArch64/lround-conv-win.ll
    M llvm/test/CodeGen/AArch64/powi-windows.ll
    M llvm/test/CodeGen/AArch64/win64-nocfi.ll
    M llvm/test/CodeGen/AArch64/win_cst_pool.ll

  Log Message:
  -----------
  [AArch64] Omit SEH directives for the epilogue if none are needed

For these cases, we already omit the prologue directives, if
(!AFI->hasStackFrame() && !windowsRequiresStackProbe && !NumBytes).

When writing the epilogue (after the prolog has been written), if
the function doesn't have the WinCFI flag set (i.e. if no prologue
was generated), assume that no epilogue will be needed either,
and don't emit any epilog start pseudo instruction. After completing
the epilogue, make sure that it actually matched the prologue.

Previously, when epilogue start/end was generated, but no prologue,
the unwind info for such functions actually was huge; 12 bytes xdata
(4 bytes header, 4 bytes for one non-folded epilogue header, 4 bytes
for padded opcodes) and 8 bytes pdata. Because the epilog consisted of
one opcode (end) but the prolog was empty (no .seh_endprologue), the
epilogue couldn't be folded into the prologue, and thus couldn't be
considered for packed form either.

On a 6.5 MB DLL with 110 KB pdata and 166 KB xdata, this gets rid of
38 KB pdata and 62 KB xdata.

Differential Revision: https://reviews.llvm.org/D88641