[all-commits] [llvm/llvm-project] 1c1a81: libclc: Use find_package to find Python 3 and requ...

Aaron Puchert via All-commits all-commits at lists.llvm.org
Thu Oct 1 13:32:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c1a8105580784c96212db1afc097a844740bc69
      https://github.com/llvm/llvm-project/commit/1c1a8105580784c96212db1afc097a844740bc69
  Author: Aaron Puchert <aaronpuchert at alice-dsl.net>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M libclc/CMakeLists.txt
    M libclc/generic/lib/gen_convert.py

  Log Message:
  -----------
  libclc: Use find_package to find Python 3 and require it

The script's shebang wants Python 3, so we use FindPython3. The
original code didn't work when an unversioned python was not available.
This is explicitly allowed in PEP 394. ("Distributors may choose to set
the behavior of the python command as follows: python2, python3, not
provide python command, allow python to be configurable by an end user
or a system administrator.")

Also I think it's actually required, so let the configuration fail if we
can't find it.

Lastly remove the shebang, since the script is only run via interpreter
and doesn't have the executable bit set anyway.

Reviewed By: jvesely

Differential Revision: https://reviews.llvm.org/D88366




More information about the All-commits mailing list