[all-commits] [llvm/llvm-project] 5665ec: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDI...

David Tenty via All-commits all-commits at lists.llvm.org
Thu Oct 1 06:45:28 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5665ec4e182dba9965847d3698ad64a950bb00a7
      https://github.com/llvm/llvm-project/commit/5665ec4e182dba9965847d3698ad64a950bb00a7
  Author: David Tenty <daltenty at ibm.com>
  Date:   2020-10-01 (Thu, 01 Oct 2020)

  Changed paths:
    M compiler-rt/cmake/base-config-ix.cmake

  Log Message:
  -----------
  [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake

It's actually not safe to call TEST_BIG_ENDIAN here, since we may be
running from the builtins build (i.e builtins-config-ix) context where
TEST_COMPILE_ONLY  is set since without builtins already built we may
fail to link, and TEST_BIG_ENDIAN internally performs tests which may
fail to link without builtins.

Fortunately powerpc is the only target that uses this information here and
we actually already know the whether we are targeting the LE variant due
to earlier macro checks, so we can simply this to remove our reliance on
TEST_BIG_ENDIAN.

Reviewed By: hubert.reinterpretcast, Whitney

Differential Revision: https://reviews.llvm.org/D88608




More information about the All-commits mailing list