[all-commits] [llvm/llvm-project] f05055: [mlir] Split Dialect::addOperations into two funct...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f0505534900bb1fcdee368136cd733aefd20ce39
      https://github.com/llvm/llvm-project/commit/f0505534900bb1fcdee368136cd733aefd20ce39
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-09-30 (Wed, 30 Sep 2020)

  Changed paths:
    M mlir/include/mlir/IR/Dialect.h

  Log Message:
  -----------
  [mlir] Split Dialect::addOperations into two functions

The current implementation uses a fold expression to add all of the operations at once. This is really nice, but apparently the lifetime of each of the AbstractOperation instances is for the entire expression which may lead to a stack overflow for large numbers of operations. This splits the method in two to allow for the lifetime of the AbstractOperation to be properly scoped.