[all-commits] [llvm/llvm-project] 3c45a0: [lld][WebAssembly] Allow exporting of mutable globals

Sam Clegg via All-commits all-commits at lists.llvm.org
Wed Sep 30 17:54:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3c45a06f26edfb7e94003adf58cb8951ea9c2ce6
      https://github.com/llvm/llvm-project/commit/3c45a06f26edfb7e94003adf58cb8951ea9c2ce6
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2020-09-30 (Wed, 30 Sep 2020)

  Changed paths:
    M lld/docs/WebAssembly.rst
    A lld/test/wasm/mutable-global-exports.s
    M lld/test/wasm/mutable-globals.s
    M lld/wasm/Writer.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Allow exporting of mutable globals

In particular allow explict exporting of `__stack_pointer` but
exclud this from `--export-all` to avoid requiring the mutable
globals feature whenenve `--export-all` is used.

This uncovered a bug in populateTargetFeatures regarding checking
if the mutable-globals feature is allowed.

See: https://github.com/WebAssembly/binaryen/issues/2934

Differential Revision: https://reviews.llvm.org/D88506




More information about the All-commits mailing list