[all-commits] [llvm/llvm-project] d68957: [lldb] Make TestGuiBasicDebug more lenient

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Sep 30 17:07:06 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d689570d7dcb16ee241676e22324dc456837eb23
      https://github.com/llvm/llvm-project/commit/d689570d7dcb16ee241676e22324dc456837eb23
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-09-30 (Wed, 30 Sep 2020)

  Changed paths:
    M lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py

  Log Message:
  -----------
  [lldb] Make TestGuiBasicDebug more lenient

Matt's change to the register allocator in 89baeaef2fa9 changed where we
end up after the `finish`. Before we'd end up on line 4.

* thread #1, queue = 'com.apple.main-thread', stop reason = step out
Return value: (int) $0 = 1
    frame #0: 0x0000000100003f7d a.out`main(argc=1, argv=0x00007ffeefbff630) at main.c:4:3
   1    extern int func();
   2
   3    int main(int argc, char **argv) {
-> 4      func(); // Break here
   5      func(); // Second
   6      return 0;
   7    }

Now, we end up on line 5.

* thread #1, queue = 'com.apple.main-thread', stop reason = step out
Return value: (int) $0 = 1

    frame #0: 0x0000000100003f8d a.out`main(argc=1, argv=0x00007ffeefbff630) at main.c:5:3
   2
   3    int main(int argc, char **argv) {
   4      func(); // Break here
-> 5      func(); // Second
   6      return 0;
   7    }

Given that this is not expected stable to be stable I've made the test a
bit more lenient to accept both scenarios.




More information about the All-commits mailing list