[all-commits] [llvm/llvm-project] 92e1eb: [trace] Fix destructor declaration

[walter erquinigo via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 92e1ebeaa1fe0e5461327d071c55167733834e60
      https://github.com/llvm/llvm-project/commit/92e1ebeaa1fe0e5461327d071c55167733834e60
  Author: Walter Erquinigo <wallace at fb.com>
  Date:   2020-09-29 (Tue, 29 Sep 2020)

  Changed paths:
    M lldb/include/lldb/Target/Trace.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h

  Log Message:
  -----------
  [trace] Fix destructor declaration

The destructor must be defined in the implementation class so that it
can be called, as Vedant Kumar pointed out in:

'''
What were your thoughts, re:

+class Trace : public PluginInterface {
+public:
+  ~Trace() override = default;

   Does this need to be `virtual ~Trace() = ...`?

      Otherwise, when a std::shared_ptr<Trace> is destroyed, the
      destructor for the derived TraceIntelPT instance won't run.
'''