[all-commits] [llvm/llvm-project] 60b852: [LoopDeletion] Forget loop before setting values t...

Florian Hahn via All-commits all-commits at lists.llvm.org
Tue Sep 29 02:48:41 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 60b852092c98dbdc6248d60109d90ae6f8ad841c
      https://github.com/llvm/llvm-project/commit/60b852092c98dbdc6248d60109d90ae6f8ad841c
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-09-29 (Tue, 29 Sep 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LoopDeletion.cpp
    M llvm/lib/Transforms/Utils/LoopUtils.cpp
    M llvm/test/Transforms/LoopDeletion/update-scev.ll

  Log Message:
  -----------
  [LoopDeletion] Forget loop before setting values to undef

After D71539, we need to forget the loop before setting the incoming
values of phi nodes in exit blocks, because we are looking through those
phi nodes now and the SCEV expression could depend on the loop phi. If
we update the phi nodes before forgetting the loop, we miss those users
during invalidation.

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D88167




More information about the All-commits mailing list