[all-commits] [llvm/llvm-project] 7a1029: Reland "[LoopUnswitch] Fix incorrect Modified status"

David via All-commits all-commits at lists.llvm.org
Thu Aug 20 02:53:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a1029fd1e415d3e21430fc18ed5cc2e79756e3c
      https://github.com/llvm/llvm-project/commit/7a1029fd1e415d3e21430fc18ed5cc2e79756e3c
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-20 (Thu, 20 Aug 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
    A llvm/test/Transforms/LoopUnswitch/convergent-hoist-modified.ll
    A llvm/test/Transforms/LoopUnswitch/invoke-hoist-modified.ll
    A llvm/test/Transforms/LoopUnswitch/optsize-hoist-modified.ll

  Log Message:
  -----------
  Reland "[LoopUnswitch] Fix incorrect Modified status"

Relanded since the buildbot issue was unrelated to this commit.

When hoisting simple values out from a loop, and an optsize attribute, a
convergent call, or an invoke instruction hindered the pass from
unswitching the loop, the pass would return an incorrect Modified
status.

This was caught using the check introduced by D80916.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D86085


  Commit: 8206257cb86b50f266df5988aa2604c836e1c95c
      https://github.com/llvm/llvm-project/commit/8206257cb86b50f266df5988aa2604c836e1c95c
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-20 (Thu, 20 Aug 2020)

  Changed paths:
    M llvm/lib/Transforms/IPO/GlobalOpt.cpp
    A llvm/test/Transforms/GlobalOpt/dead-store-status.ll

  Log Message:
  -----------
  [GlobalOpt] Fix an incorrect Modified status

When removing a non-constant store to a global in
CleanupPointerRootUsers(), the GlobalOpt pass could incorrectly return
false.

This was caught using the check introduced by D80916.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D86149


Compare: https://github.com/llvm/llvm-project/compare/b43235a76c23...8206257cb86b


More information about the All-commits mailing list