[all-commits] [llvm/llvm-project] e9b236: AMDGPU: Check for other defs when folding conditio...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jul 28 13:36:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e9b236f411c5683d270a381bf810ba3c8f3ed12c
      https://github.com/llvm/llvm-project/commit/e9b236f411c5683d270a381bf810ba3c8f3ed12c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
    A llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-loop-phi.mir

  Log Message:
  -----------
  AMDGPU: Check for other defs when folding conditions into s_andn2_b64

We can't fold the masked compare value through the select if the
select condition is re-defed after the and instruction. Fixes a
verifier error and trying to use the outgoing value defined in the
block.

I'm not sure why this pass is bothering to handle physregs. It's
making this more complex and forces extra liveness computation.




More information about the All-commits mailing list