[all-commits] [llvm/llvm-project] e1dd21: [X86] Remove disabled miscompiling X86CondBrFoldin...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e1dd212c874c2ff01b72e9e60db6dbded9e2e6d1
      https://github.com/llvm/llvm-project/commit/e1dd212c874c2ff01b72e9e60db6dbded9e2e6d1
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M llvm/lib/Target/X86/CMakeLists.txt
    M llvm/lib/Target/X86/X86.h
    M llvm/lib/Target/X86/X86.td
    R llvm/lib/Target/X86/X86CondBrFolding.cpp
    M llvm/lib/Target/X86/X86Subtarget.h
    M llvm/lib/Target/X86/X86TargetMachine.cpp
    M llvm/lib/Target/X86/X86TargetTransformInfo.h
    R llvm/test/CodeGen/X86/condbr_if.ll
    R llvm/test/CodeGen/X86/condbr_switch.ll
    R llvm/test/CodeGen/X86/test_x86condbr_globaladdr.mir
    M llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn

  Log Message:
  -----------
  [X86] Remove disabled miscompiling X86CondBrFolding pass

As briefly discussed in IRC with @craig.topper,
the pass is disabled basically since it's original introduction (nov 2018)
due to  known correctness issues (miscompilations),
and there hasn't been much work done to fix that.

While i won't promise that i will "fix" the pass,
i have looked at it previously, and i'm sure i won't try to fix it
if that requires actually fixing this existing code.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D84775