[all-commits] [llvm/llvm-project] 919922: [mlir] Added verification check for linalg.conv to...

Jakub Lichman via All-commits all-commits at lists.llvm.org
Thu Jul 23 03:27:29 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 919922b0c20e99de51bb0d06c98a5fc2fa5feec4
      https://github.com/llvm/llvm-project/commit/919922b0c20e99de51bb0d06c98a5fc2fa5feec4
  Author: Jakub Lichman <limo at google.com>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
    M mlir/test/Dialect/Linalg/invalid.mlir

  Log Message:
  -----------
  [mlir] Added verification check for linalg.conv to ensure memrefs are of rank > 2

linalg.conv does not support memrefs with rank smaller than 3 as stated here:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/nn/convolution

However it does not verify it and thus crashes with "LLVM ERROR: out of memory"
error for 1D case and "nWin > 0 && "expected at least one window dimension"" assertion
for 2D case. This commit adds check for that in the verification method.

Differential Revision: https://reviews.llvm.org/D84317




More information about the All-commits mailing list