[all-commits] [llvm/llvm-project] 9020d2: [libcxx][lit] Fix incorrect lambda capture in hasL...

[Alexander Richardson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9020d28688492c437abb648b6ab69baeba523219
      https://github.com/llvm/llvm-project/commit/9020d28688492c437abb648b6ab69baeba523219
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M libcxx/utils/libcxx/test/dsl.py
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx][lit] Fix incorrect lambda capture in hasLocale checks

The lambda being used to check whether locales are supported was always
passing the value of alts from the last loop iteration due to the way that
python lambda captures work. Fix this by using a default argument capture.

To help debug future similar issues I also added a prefix to the config
test binary indicating which locale is being tested.
I originally found this issue when implementing a new executor that simply
collects test binaries in a given directory and was surprised to see many
additional executables other than the expected test binaries. I therefore
added the locale prefix to the test binaries and noticed that they were all
checking for cs_CZ.ISO8859-2.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D84040


  Commit: 722e5d6aaeb5ec0e75506de19e582302c65734cc
      https://github.com/llvm/llvm-project/commit/722e5d6aaeb5ec0e75506de19e582302c65734cc
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M llvm/utils/lit/lit/reports.py
    M llvm/utils/lit/tests/shtest-format.py
    M llvm/utils/lit/tests/xunit-output.py

  Log Message:
  -----------
  [lit] Include total elapsed time in xunit output

The time= attribute can also be used for the testsuites tag. While this
attribute appears to be ignored by Jenkins (https://github.com/jenkinsci/junit-plugin/blob/bab34bcc96154a494f8c371953efe06d45813f67/src/main/java/hudson/tasks/junit/SuiteResult.java#L202),
it is still useful if you manually inspect the xml file.

Reviewed By: yln

Differential Revision: https://reviews.llvm.org/D84230


Compare: https://github.com/llvm/llvm-project/compare/1162ffe8f4b7...722e5d6aaeb5