[all-commits] [llvm/llvm-project] 169261: [lldb] Only set the executable module for a target...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 16926115ed28d1370bca1085dfb1b20c842b0ffb
      https://github.com/llvm/llvm-project/commit/16926115ed28d1370bca1085dfb1b20c842b0ffb
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
    A lldb/test/API/functionalities/dlopen_other_executable/Makefile
    A lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
    A lldb/test/API/functionalities/dlopen_other_executable/main.c
    A lldb/test/API/functionalities/dlopen_other_executable/other.c

  Log Message:
  -----------
  [lldb] Only set the executable module for a target once

Summary:

When we try to find the executable module for our target we don't check
if we already have an executable module set. This causes that when debugging
a program that dlopens another executable, LLDB will take that other executable
as the new executable of the target (which causes that future launches of the
target will launch the dlopen'd executable instead of the original executable).

This just adds a check that we only set the executable when we haven't already
found one.

Fixes rdar://63443099

Reviewers: jasonmolenda, jingham, teemperor

Reviewed By: jasonmolenda, teemperor

Subscribers: jingham, JDevlieghere

Differential Revision: https://reviews.llvm.org/D80724