[all-commits] [llvm/llvm-project] 2b6215: [NFC] Add tests for boolean comparisons

[Roger Ferrer Ibáñez via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b6215f188bf862d5a551499764121d91fd6e6ea
      https://github.com/llvm/llvm-project/commit/2b6215f188bf862d5a551499764121d91fd6e6ea
  Author: Roger Ferrer Ibanez <roger.ferrer at bsc.es>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    A llvm/test/CodeGen/AArch64/cmp-bool.ll
    A llvm/test/CodeGen/ARM/cmp-bool.ll
    A llvm/test/CodeGen/RISCV/cmp-bool.ll
    A llvm/test/CodeGen/X86/cmp-bool.ll

  Log Message:
  -----------
  [NFC] Add tests for boolean comparisons

They currently show that the not equal case may be improved.

See PR42876

Differential Revision: https://reviews.llvm.org/D65801


  Commit: 14bc5e149d11766dee21cd679a9794fdf2e9414e
      https://github.com/llvm/llvm-project/commit/14bc5e149d11766dee21cd679a9794fdf2e9414e
  Author: Roger Ferrer Ibanez <roger.ferrer at bsc.es>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AArch64/cmp-bool.ll
    M llvm/test/CodeGen/ARM/cmp-bool.ll
    M llvm/test/CodeGen/RISCV/cmp-bool.ll
    M llvm/test/CodeGen/WebAssembly/reg-stackify.ll
    M llvm/test/CodeGen/X86/cmp-bool.ll

  Log Message:
  -----------
  [DAGCombiner] Rebuild (setcc x, y, ==) from (xor (xor x, y), 1)

The existing code already considered this case. Unfortunately a typo in
the condition prevents it from triggering. Also the existing code, had
it run, forgot to do the folding.

This fixes PR42876.

Differential Revision: https://reviews.llvm.org/D65802


Compare: https://github.com/llvm/llvm-project/compare/d431951343cd...14bc5e149d11