[all-commits] [llvm/llvm-project] d43195: [MLIR][SPIRVToLLVM] SPIRV function fix and nits

George Mitenkov via All-commits all-commits at lists.llvm.org
Wed Jul 15 00:31:06 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d431951343cdaa301cbd72743fde8114b93f9d33
      https://github.com/llvm/llvm-project/commit/d431951343cdaa301cbd72743fde8114b93f9d33
  Author: George Mitenkov <georgemitenk0v at gmail.com>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp

  Log Message:
  -----------
  [MLIR][SPIRVToLLVM] SPIRV function fix and nits

This patch addresses the comments from https://reviews.llvm.org/D83030 and
https://reviews.llvm.org/D82639. `this->` is removed when not inside the
template. Also, type conversion for `spv.func` takes `convertRegionTypes()`
in order to apply type conversion on all blocks within the function.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D83786




More information about the All-commits mailing list