[all-commits] [llvm/llvm-project] 3faec8: [lldb] Fix missing characters when autocompleting ...

Martin Svensson via All-commits all-commits at lists.llvm.org
Fri Jul 3 03:10:36 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3faec833760fa7ab6e3180378da8c8fb4abbdb11
      https://github.com/llvm/llvm-project/commit/3faec833760fa7ab6e3180378da8c8fb4abbdb11
  Author: Martin Svensson <poya at me.com>
  Date:   2020-07-03 (Fri, 03 Jul 2020)

  Changed paths:
    M lldb/source/Expression/REPL.cpp

  Log Message:
  -----------
  [lldb] Fix missing characters when autocompleting LLDB commands in REPL

Summary:

When tabbing to complete LLDB commands in REPL, characters would at best be
missing but at worst cause the REPL to crash due to out of range string access.
This patch appends the command character to the completion results to fulfill
the assumption that all matches are prefixed by the request's cursor argument
prefix.

Bug report for the Swift REPL
https://bugs.swift.org/browse/SR-12867

Reviewers: teemperor

Reviewed By: teemperor

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D82835




More information about the All-commits mailing list