[all-commits] [llvm/llvm-project] b6f08b: [DWARFYAML][debug_gnu_*] Add the missing context `...

Xing GUO via All-commits all-commits at lists.llvm.org
Fri Jul 3 03:08:55 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b6f08b7cfd05f6a58b4e30d90bc0e630ff6a7aa5
      https://github.com/llvm/llvm-project/commit/b6f08b7cfd05f6a58b4e30d90bc0e630ff6a7aa5
  Author: Xing GUO <higuoxing at gmail.com>
  Date:   2020-07-03 (Fri, 03 Jul 2020)

  Changed paths:
    M llvm/include/llvm/ObjectYAML/DWARFEmitter.h
    M llvm/include/llvm/ObjectYAML/DWARFYAML.h
    M llvm/lib/ObjectYAML/DWARFEmitter.cpp
    M llvm/lib/ObjectYAML/DWARFYAML.cpp
    M llvm/tools/obj2yaml/dwarf2yaml.cpp
    M llvm/unittests/ObjectYAML/DWARFYAMLTest.cpp

  Log Message:
  -----------
  [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

This patch helps add the missing context `IsGNUStyle`. Before this patch, yaml2obj cannot parse the YAML description of 'debug_gnu_pubnames' and 'debug_gnu_pubtypes' correctly due to the missing context.

In other words, if we have

```
DWARF:
  debug_gnu_pubtypes:
    Length:
      TotalLength: 0x1234
    Version:    2
    UnitOffset: 0x1234
    UnitSize:   0x4321
    Entries:
      - DieOffset:  0x12345678
        Name:       abc
        Descriptor: 0x00      ## Descriptor can never be mapped into Entry.Descriptor
```

yaml2obj will complain that "error: unknown key 'Descriptor'".

This patch helps resolve this problem.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D82435




More information about the All-commits mailing list