[all-commits] [llvm/llvm-project] df9d64: [IR] Add missing GlobalAlias copying of ThreadLoca...

[nextsilicon-itay-bookstein via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: df9d64ed9c1d819bc0a040e3ef4c4a4003bf5c93
      https://github.com/llvm/llvm-project/commit/df9d64ed9c1d819bc0a040e3ef4c4a4003bf5c93
  Author: Itay Bookstein <itay.bookstein at nextsilicon.com>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M llvm/lib/IR/Globals.cpp
    A llvm/test/Linker/Inputs/alias-threadlocal-defs.ll
    A llvm/test/Linker/alias-threadlocal.ll

  Log Message:
  -----------
  [IR] Add missing GlobalAlias copying of ThreadLocalMode attribute

Summary:
Previously, GlobalAlias::copyAttributesFrom did not preserve ThreadLocalMode,
causing incorrect IR generation in IR linking flows. This patch pushes the code
responsible for copying this attribute from GlobalVariable::copyAttributesFrom
down to GlobalValue::copyAttributesFrom so that it is shared by GlobalAlias.
Fixes PR46297.

Reviewers: tejohnson, pcc, hans

Reviewed By: tejohnson, hans

Subscribers: hiraditya, ibookstein, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81605