[all-commits] [llvm/llvm-project] 328230: GlobalISel: Set instr/debugloc before any legalize...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jun 9 12:37:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 32823091c36cfa2b27b717246f15d4f12591e6f4
      https://github.com/llvm/llvm-project/commit/32823091c36cfa2b27b717246f15d4f12591e6f4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
    M llvm/lib/Target/Mips/MipsLegalizerInfo.cpp
    M llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

  Log Message:
  -----------
  GlobalISel: Set instr/debugloc before any legalizer action

It was annoying enough that every custom lowering needed to set the
insert point, but this was made worse since now these all needed to be
updated to setInstrAndDebugLoc. Consolidate these so every
legalization action has the right insert position by default.

This should fix dropping debug info in every custom AMDGPU
legalization.




More information about the All-commits mailing list