[all-commits] [llvm/llvm-project] 0e0434: [NFCI] Clean up exceptions related CMake and Lit o...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e04342ae0399876f3488464d12f5a4da5085456
      https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M libcxxabi/test/libcxxabi/test/config.py
    M libunwind/test/CMakeLists.txt
    M libunwind/test/libunwind/test/config.py
    M libunwind/test/lit.cfg
    M libunwind/test/lit.site.cfg.in

  Log Message:
  -----------
  [NFCI] Clean up exceptions related CMake and Lit options in libc++abi and libunwind

First, libc++abi doesn't need to add the no-exceptions Lit feature itself,
since that is already done in the config.py for libc++, which it reuses.
Specifically, config.enable_exceptions is set based on @LIBCXXABI_ENABLE_EXCEPTIONS@
in libc++abi's lit.cfg.in, and libc++'s config.py handles that correctly.

Secondly, libunwind's LIBUNWIND_ENABLE_EXCEPTIONS is never set (it's
probably a remnant of copy-pasting code between the runtime libraries),
so the library is always built with exceptions disabled (which makes
sense since it implements the runtime support for exceptions).
Conversely, the test suite is always run with exceptions enabled
(not sure why), but that is preserved by the default behavior of
libc++'s config.py.