[all-commits] [llvm/llvm-project] e3547a: [DebugInfo] Improve new line printing in debug lin...

[James Henderson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e3547ade68232d74bffd0e126cc0ea0b3970fbf7
      https://github.com/llvm/llvm-project/commit/e3547ade68232d74bffd0e126cc0ea0b3970fbf7
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    M llvm/test/tools/llvm-dwarfdump/X86/verbose.test
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

  Log Message:
  -----------
  [DebugInfo] Improve new line printing in debug line verbose output

The new line printing for debug line verbose output was inconsistent.
For new rows in the matrix, a blank line followed, whilst the
DW_LNS_copy opcode actually resulted in two blank lines. There was also
potential inconsistency in the blank lines at the end of the table. This
patch mostly resolves these issues - no blank lines appear in the output
except for a single line after the prologue and at table end to separate
it from any subsquent table, plus some instances after error messages.

Also add a unit test for verbose output to test the fine details of new
line placement and other aspects of verbose output.

Reviewed by: dblaikie

Differential Revision: https://reviews.llvm.org/D81102