[all-commits] [llvm/llvm-project] dbd26f: [DebugInfo] Print non-verbose output at some point...

James Henderson via All-commits all-commits at lists.llvm.org
Tue Jun 9 06:25:26 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dbd26fe0b6ac8b33067817ef770d82afbe268c05
      https://github.com/llvm/llvm-project/commit/dbd26fe0b6ac8b33067817ef770d82afbe268c05
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_dwarf64_large_table.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

  Log Message:
  -----------
  [DebugInfo] Print non-verbose output at some point as verbose output

Verbose and non-verbose parsing of .debug_line produced their output at
different points in the program. The most obvious impact of this was
that error messages were produced at different times, but it also
potentially reduced what clients could do by customising the stream or
warning/error handlers.

This change makes the two variants consistent by printing non-verbose
output inline, the same as verbose output.

Testing of the error messages has been modified to check the messages
always appear in the same location to illustrate the behaviour.

Reviewed by: JDevlieghere, dblaikie, MaskRay, labath

Differential Revision: https://reviews.llvm.org/D80989




More information about the All-commits mailing list