[all-commits] [llvm/llvm-project] e7f106: [lldb/Reproducers] Skip API logging in the DUMMY m...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed May 27 10:36:02 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e7f1067ad6f116ff1e4bfc0f7fe1977f172b0ea0
      https://github.com/llvm/llvm-project/commit/e7f1067ad6f116ff1e4bfc0f7fe1977f172b0ea0
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ReproducerInstrumentation.h
    M lldb/source/Utility/ReproducerInstrumentation.cpp

  Log Message:
  -----------
  [lldb/Reproducers] Skip API logging in the DUMMY macro

The purpose of the LLDB_RECORD_DUMMY macro is twofold: it is used in
functions that take arguments that we don't know how to serialize (e.g.
void*) and it's used by function where we want to avoid doing excessive
work because they can be called from a signal handler (e.g.
setTerminalWidth).

To support the latter case, I've disabled API logging form the Recorder
ctor used by the DUMMY macro. This ensures we don't allocate memory when
called from a signal handler.




More information about the All-commits mailing list